Skip to content

feat: Add bashIde.shfmt.additionalArguments LSP setting. - #1387

Merged
skovhus merged 5 commits into
bash-lsp:mainfrom
kylechui:main
Sep 16, 2026
Merged

feat: Add bashIde.shfmt.additionalArguments LSP setting.#1387
skovhus merged 5 commits into
bash-lsp:mainfrom
kylechui:main

Conversation

@kylechui

@kylechui kylechui commented Jul 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This will allow a user to extend the arguments being passed to the shfmt binary, and resolve #1385.

NOTE: I think that some of the tests had their number of arguments increased by one, since my wrapper makeShfmtConfig will impute languageDialect: 'auto' when it used to be omitted.

@kylechui
feat: Add bashIde.shfmt.additionalArguments LSP setting.
75585f9 
This will allow a user to extend the arguments being passed to the shfmt
binary, and resolve bash-lsp#1385.
@kylechui
kylechui marked this pull request as draft July 3, 2026 15:18
@kylechui

kylechui commented Jul 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

The tests are largely passing my local machine, except for a few that rely on the get-options.sh script. I think this is because I am running NixOS, which doesn't store those completion files in the Linux FHS. I imagine if the CI for this project has tests that spin up the language server in a virtual machine, then they should pass.

@kylechui
kylechui marked this pull request as ready for review July 3, 2026 15:50
@skovhus
skovhus enabled auto-merge July 27, 2026 09:59
@skovhus
skovhus disabled auto-merge July 27, 2026 10:00
@skovhus

skovhus commented Sep 14, 2026

Copy link
Copy Markdown
Collaborator

@kylechui do you mind fixing the test that fails on CI?

@codecov

codecov Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 75.00000% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.25%. Comparing base (8309808) to head (78220c9).
⚠️ Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
server/src/config.ts 71.42% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1387      +/-   ##
==========================================
- Coverage   80.29%   80.25%   -0.04%     
==========================================
  Files          29       29              
  Lines        1578     1585       +7     
  Branches      389      392       +3     
==========================================
+ Hits         1267     1272       +5     
- Misses        248      249       +1     
- Partials       63       64       +1

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@skovhus
skovhus merged commit 5ffc281 into bash-lsp:main Sep 16, 2026
6 checks passed
@kylechui

kylechui commented Sep 16, 2026

Copy link
Copy Markdown
Contributor Author

Ah sorry for the late response, thanks for pushing this through!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@skovhus skovhus skovhus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Allow multi-argument commands to start up shfmt

2 participants

@kylechui @skovhus